fix: decline proof #1435
Merged
fix: decline proof #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
bryce-mcmath
reviewed
Feb 7, 2025
| @@ -163,6 +163,11 @@ const NotificationListItem: React.FC<NotificationListItemProps> = ({ | |||
| try { | |||
| const proofId = (notification as ProofExchangeRecord).id | |||
| if (agent) { | |||
| const connection = await agent.connections.findById(proofId) | |||
There was a problem hiding this comment.
This method expects a connectionId no? Will a proofId work as expected? Are the two always the same?
There was a problem hiding this comment.
ProofExchangeRecord has a connectionId
There was a problem hiding this comment.
Oof. Yes, not sure what I was thinking here.
| @@ -561,7 +561,11 @@ const ProofRequest: React.FC<ProofRequestProps> = ({ navigation, proofId }) => { | |||
| const handleDeclineTouched = useCallback(async () => { | |||
| try { | |||
| if (agent && proof) { | |||
| await agent.proofs.sendProblemReport({ proofRecordId: proof.id, description: t('ProofRequest.Declined') }) | |||
| const connection = await agent.connections.findById(proof.id) | |||
Signed-off-by: Jason C. Leach <[email protected]>
|
al-rosenthal
approved these changes
Feb 8, 2025
|
If there ends up being any issue remaining for this we may just have to add an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes a bug that occurred when declining a proof request from a notification. If the contact associated with that proof request had their connection deleted, the app would throw a visible error. This happened because the app tried to send a problem report related to the declined proof, but sending a problem report requires an active connection, which no longer existed. This change prevents that error from occurring.
Screenshots, videos, or gifs
n/a
Breaking change guide
n/a
Related Issues
n/a
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓