Fix problem with implied multiplication in fraction context, and some typos. (#1166) #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Jordan
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
I tested and the exercises that were not working from #1166 are working now. Thanks for this!
drgrice1
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem raised in #1166. This was due to mishandling of the "space" operator used for implied multiplication. The issue resulted from setting the cached operator definition to the
stringoperator, but mutating the operator to the wrong class in some instances (it should be to the class for the new operator, not the original space operator's class).This PR checks whether to mutate to the original space class or to bless the operator to the
stringoperator's class.It also fixes a couple of typos (one in an unrelated file -- hope that is OK).
Resolves issue #1166.