Give explicit multiplication the special mq_precedence as well. #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Jan 14, 2025
drgrice1
force-pushed
the
explicit-multiplication-mq-prec
branch
from
9677109 to
79f9625
Compare
Implied multiplication ` *` currently has the precedence of 2.9 when
MathQuill is used. This means that `(x-3)/4 (x+8)/7` is interpreted as
`\frac{(x-3)}{4} * \frac{(x+8)}{7}`.
However, `(x-3)/4 * (x+8)/7` is interpreted as
`\frac{\frac{(x-3)/4 * (x+8)}{7}`. That should also be interpreted as
`\frac{(x-3)}{4} * \frac{(x+8)}{7}` and is with the mq_precendence for
`* ` also set to 2.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implied multiplication
*currently has the precedence of 2.9 when MathQuill is used. This means that(x-3)/4 (x+8)/7is interpreted as\frac{(x-3)}{4} * \frac{(x+8)}{7}.However,
(x-3)/4 * (x+8)/7is interpreted as\frac{\frac{(x-3)/4 * (x+8)}{7}. That should also be interpreted as\frac{(x-3)}{4} * \frac{(x+8)}{7}and is with the mq_precendence for*also set to 2.9.Note that @dpvc mentioned considering changing this precedence in general and dropping the special
mq_precedence. Should this be considered? See #1107 (comment) and the discussion after it. Although, does that still apply with the*operator?