Prevent the click event on a solution or hint accordion button instead of the details.
#1179
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Jan 15, 2025
drgrice1
force-pushed
the
details-accordion-selectively-prevent-click
branch
from
6dacc14 to
db3a74c
Compare
…ead of the details. Add `e.preventDefault()` to the `summary.accordion-button` `click` event listener instead of preventing all clicks on the `details` tag. This fixes issue openwebwork#1178.
drgrice1
force-pushed
the
details-accordion-selectively-prevent-click
branch
from
db3a74c to
4a36b0b
Compare
drgrice1
changed the title
click event on a solution or hint accordion.click event on a solution or hint accordion button instead of the details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only prevent the default click behavior when the user clicks on the summary or something within the summar. Allow the click event default to occur otherwise.Instead add
e.preventDefault()to thesummary.accordion-buttonclickevent listener instead of preventing all clicks on thedetailstag.This fixes issue #1178.
This could be made into a hotfix if desired.