-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sample problems and updates #1201
base: develop
Are you sure you want to change the base?
New sample problems and updates #1201
Conversation
I have merged #1195, and it changed since you opened this PR. I haven't looked but I suspect you may want to revise the sample problem for that tool. |
8262836
to
05316f6
Compare
Just updated the sample problem for the vector graph tool and added a line segment graph tool problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several changes needed here.
First , please reformat the problems that you added. Always try to fit into an 80 character text width whenever possible. That is what we have the pg perltidy script set to use. One reason for that is that even with a wide browser window anything more will wrap and look bad in the problem editor.
Note that the sample-problems/Geometry/LineSegmentGraphTool.pg
problem is not in the set definition file that you posted. I am just noting this so that others testing this pull request will know to add it (or look at it in a different way).
Update existing problems. This includes * removing the subjects of 'answer' and 'graphs' and reclassifying appropriate places for these problems. * running perltidy again on the sample problems. * adding some additional links (categories, see_also, ..)
Also, add a Line Segment tool, which was also just added.
05316f6
to
373ae73
Compare
I think the couple that I reformatted to be more narrow was just due to a narrow screen I was using in the ProblemEditor. If I use vscode, I get the 80 limit as a vertical line. Do you know if CodeMirror6 has the ability to include a vertical line at a given width. That might be helpful. I have made updates on these and just pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I asked that the problems be formatted to fit into the 80 character limit, I mean the entire problem. That means documentation and PGML sections as well. That is what I did with the existing sample problems in the last related pull request. I see this still has not been done.
I double checked all of the problems. The only cases that I think remain is when the categories or sample problems list goes beyond, but I think we'd have to rewrite the script to handle that. |
That is better. Yeah, the categories have to be on the same line at this point. The next thing to look at is the wording in the documentation of the new problems. For example, in the
First it has the "royal we" I said to try and get rid of. Second, it is a run on sentence. Then a few lines later in the same documentation it states:
Technically that is not a run on sentence, but it is a conjunction between two sentences that are really unrelated, and reads quite poorly. |
I do use the royal "we" and will look overthing again. |
Made some more changes. Got rid of the royal "we" and tried to be more consistent with the style of the other problems. |
Added new Sample problems and updated existing problems.
Updates includes
Note: for the new VectorGraphTool problem, #1195 needs to be merged.
I've also updated the list of sample problems that @drgrice1 posted earlier to
setSample_Problems.def.txt