Merge pull request #2566 from Alex-Jordan/hotfix/lms-grade-items

hotfix variant of #2561
openwebwork · Oct 1, 2024 · 095521d · 095521d
2 parents fa3468a + d3935df
commit 095521d
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 11 deletions.
diff --git a/lib/WeBWorK/ContentGenerator/LTIAdvanced.pm b/lib/WeBWorK/ContentGenerator/LTIAdvanced.pm
@@ -129,8 +129,19 @@ sub content_selection ($c) {
 						? {
 							'@type'   => 'LtiLinkItem',
 							mediaType => 'application/vnd.ims.lti.v1.ltilink',
-							title     => $c->maketext('Assignments'),
-							url       => $c->url_for('set_list', courseID => $c->stash->{courseID})->to_abs->to_string
+							title     => $c->maketext('WeBWorK Assignments'),
+							url       => $c->url_for('set_list', courseID => $c->stash->{courseID})->to_abs->to_string,
+							$c->ce->{LTIGradeMode} eq 'course'
+							? (
+								lineItem => {
+									'@type'          => 'LineItem',
+									scoreConstraints => {
+										'@type'       => 'NumericLimits',
+										normalMaximum => 100
+									}
+								}
+								)
+							: ()
 							}
 						: (),
 						map { {
@@ -141,13 +152,17 @@ sub content_selection ($c) {
 							url =>
 								$c->url_for('problem_list', courseID => $c->stash->{courseID}, setID => $_->set_id)
 								->to_abs->to_string,
-							lineItem => {
-								'@type'          => 'LineItem',
-								scoreConstraints => {
-									'@type'       => 'NumericLimits',
-									normalMaximum => $setMaxScores{ $_->set_id }
+							$c->ce->{LTIGradeMode} eq 'homework'
+							? (
+								lineItem => {
+									'@type'          => 'LineItem',
+									scoreConstraints => {
+										'@type'       => 'NumericLimits',
+										normalMaximum => $setMaxScores{ $_->set_id }
+									}
 								}
-							}
+								)
+							: ()
 						} } @selectedSets
 					]
 				})

diff --git a/lib/WeBWorK/ContentGenerator/LTIAdvantage.pm b/lib/WeBWorK/ContentGenerator/LTIAdvantage.pm
@@ -266,8 +266,9 @@ sub content_selection ($c) {
 						$c->param('course_home_link')
 						? {
 							type  => 'ltiResourceLink',
-							title => $c->maketext('Assignments'),
-							url   => $c->url_for('set_list', courseID => $c->stash->{courseID})->to_abs->to_string
+							title => $c->maketext('WeBWorK Assignments'),
+							url   => $c->url_for('set_list', courseID => $c->stash->{courseID})->to_abs->to_string,
+							$c->ce->{LTIGradeMode} eq 'course' ? (lineItem => { scoreMaximum => 100 }) : ()
 							}
 						: (),
 						map { {
@@ -277,7 +278,9 @@ sub content_selection ($c) {
 							url =>
 								$c->url_for('problem_list', courseID => $c->stash->{courseID}, setID => $_->set_id)
 								->to_abs->to_string,
-							lineItem => { scoreMaximum => $setMaxScores{ $_->set_id } }
+							$c->ce->{LTIGradeMode} eq 'homework'
+							? (lineItem => { scoreMaximum => $setMaxScores{ $_->set_id } })
+							: ()
 						} } @selectedSets
 					]
 					)