Skip to content

Commit

Permalink
Remove the attempt to prevent the user list table caption from scrolling
Browse files Browse the repository at this point in the history
horizontally.  That isn't working.

Also improve the spacing of the text above the table by not using `p`
tags.
  • Loading branch information
drgrice1 committed Jun 25, 2024
1 parent 8093b83 commit 09f051d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
8 changes: 0 additions & 8 deletions htdocs/js/UserList/userlist.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
.edit-classlist-table-container {
margin-top: 38px;

table.table {
border-collapse: separate;
border-spacing: 0;
Expand All @@ -19,12 +17,6 @@
border-right: var(--bs-border-width) solid var(--bs-table-border-color);
}

caption {
position: absolute;
z-index: 1;
margin-top: -84px;
}

th:first-child,
td:first-child {
position: sticky;
Expand Down
10 changes: 6 additions & 4 deletions templates/ContentGenerator/Instructor/UserList.html.ep
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,16 @@
<%= submit_button maketext($formTitles->{$default_choice}), id => 'take_action', class => 'btn btn-primary' =%>
</div>
%
<p class="mb-0"><%= maketext('Showing [_1] out of [_2] users',
scalar(keys %{ $c->{visibleUserIDs} }), scalar(@{ $c->{allUserIDs} })) =%></p>
<div>
<%= maketext('Showing [_1] out of [_2] users',
scalar(keys %{ $c->{visibleUserIDs} }), scalar(@{ $c->{allUserIDs} })) =%>
</div>
%
% if ($c->{editMode}) {
<p>
<div>
<%= maketext(
'Click on the login name to edit individual problem set data, (e.g. due dates) for these students.') =%>
</p>
</div>
% }
%
<%= include 'ContentGenerator/Instructor/UserList/user_list' =%>
Expand Down

0 comments on commit 09f051d

Please sign in to comment.