check_modules.pl allow newer versions of node. #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdrew42
approved these changes
Nov 6, 2023
|
That is true. So we will need to monitor past versions of node and increment the minimum required version as needed. At this point version 16 still works. |
Allow any version of node that is 16 or newer. Don't insist on version 16 exactly. I am currently using node 20 and was using 18 before that. I haven't seen any issues with these newer versions.
drgrice1
force-pushed
the
check-modules-updates
branch
from
bf25cc8 to
dc05cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow any version of node that is 16 or newer. Don't insist on version 16 exactly. I am currently using node 20 and was using 18 before that. I haven't seen any issues with these newer versions.