icons indicated exercise set type #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Jordan
force-pushed
the
set-type-icons
branch
from
62083f2 to
81a28a5
Compare
|
I forget if we had conclusions about this from today to change it. Some questions might be:
I lean toward simplicity and just having the one test icon and no more clock. So the "Homework Sets" page ("Assignments" once #2265 is merged) would only have one possible icon showing. And then in "Set Manager" ("Sets Manager") there would also be the icon indicating JITAR. |
|
That sounds good to me. |
|
For the JITAR icon, we could go with this icon instead :) |
drgrice1
approved these changes
Nov 28, 2023
templates/ContentGenerator/Instructor/ProblemSetList/set_list_row.html.ep
Outdated
Show resolved
Hide resolved
Co-authored-by: Glenn Rice <[email protected]>
…row.html.ep Co-authored-by: Glenn Rice <[email protected]>
|
Thanks, I committed both suggestions. |
pstaabp
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a clock icon for sets that are timed tests which are still open to take. This appears on the main "Homework Sets" page.
This adds another icon for all other tests, so that there is an indicator that the set is a test (because that is not always clear from the name an instructor gives to the test.)
Additionally, these icons now appear in the Set Manager table so that the instructor can easily see where the tests are.
Lastly, the instructor might also want to see which sets are JITAR sets while in the Set Manager, so there is an icon for this too. I left that out of the "Homework Sets" page because I am not sure how useful that indicator would be for students.