Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering the user list by permission level or status for other languages. #2268

Merged

Conversation

drgrice1
Copy link
Member

Currently when filtering by permission level or status the text entered in the "Filter by what text?" field is matched against the untranslated permission level name or status name. As a result other languages must enter the English names for these to match what is displayed translated which is probably very confusing. This just matches against the translated names.

This fixes issue #1093.

@dlglin
Copy link
Member

dlglin commented Nov 30, 2023

It would be nice if when filtering by a column with a fixed list of choices the user was given a drop-down of the available choices rather than having to type them. For the Classlist Editor (I forget the new name) this would apply to permission level and status, but this is beyond the scope of this PR.

@drgrice1
Copy link
Member Author

Yeah, I was thinking the same thing, but I just wanted to close that relatively old issue!

@drgrice1 drgrice1 force-pushed the userlist-filter-on-translated branch from 92528cc to e0911ff Compare December 4, 2023 22:38
@taniwallach
Copy link
Member

This change will take getting used to for non-English users who got used to filtering using the English permission levels.
I recommend matching on both the English string and the translated string. That is an extra string match, but will not break what works at present for staff in non-English courses.
Once there is a move to a pull-down menu - using only the translated string seems OK to me.

…anguages.

Currently when filtering by permission level or status the text entered
in the "Filter by what text?" field is matched against the untranslated
permission level name or status name.  As a result other languages must
enter the English names for these to match what is displayed translated
which is probably very confusing.  This now matches against the
translated names as well as the untranslated names.

This fixes issue openwebwork#1093.
@drgrice1 drgrice1 force-pushed the userlist-filter-on-translated branch from e0911ff to 82f1840 Compare December 5, 2023 15:22
@drgrice1
Copy link
Member Author

drgrice1 commented Dec 5, 2023

I updated the pull request to compare to both the translated and untranslated strings. I actually initially implemented it this way, but decided to instead only use the translated string because that is what is visible to the end user. So this is just for old timers that are stuck in their ways!

Copy link
Member

@taniwallach taniwallach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting the old methods keep working.

@Alex-Jordan Alex-Jordan merged commit 2b193de into openwebwork:develop Dec 16, 2023
1 check passed
@drgrice1 drgrice1 deleted the userlist-filter-on-translated branch December 17, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants