adjustments to date extension achievement items

[Alex-Jordan]

This addresses some issues I've had in practice with these achievement items.

• A student is aware they have an item that can extend a due date 24 (or 48) hours. They have a set that closes at, say, 10:00pm. Their expectation is often that they can let the due date pass, then use the extension item. (They are not thinking to abuse the system by viewing answers; they are just thinking it shouldn't matter.) But that is not how it currently works. So the first change here is that if it is within the 24 (or 48) hour window after a close date, you can still use the reward item. [The only reason not to allow them to use it indefinitely is to save them from wasting it.]
• This then raises the issue of a set closing, and possibly the answer date passes too, and the student can see all the answers. So if they use the reward item in that 24 (or 48) hour window, the set's seeds are all re-randomized. (No attempt is made to leave the seeds alone where the student already had status 1.)
• Currently, these reward items always push back the answer date along with the close date. But that can leave them in a position where the set has closed for them (as well as for all other students), and other students have access to answers, but this student does not. So the last change here is to only push the answer date back to whatever the new close date is, or leave it alone, whichever is later.

And then there is ExtendDueDateGW. This is not used by the default set of achievements, so I wonder if anyone even uses it. If anyone does use it, they are likely power users with extensive understanding of achievements. I started editing this one to make the same changes, but this reward item makes little sense to me in the first place. It adds 24 hours to a test template set, which seems perfectly reasonable to me. But it also adds 24 hours to every test version. So a student who activated a test that was only supposed to be 1 hour long could use this and have the test open for 25 hours. And it seems like that is not the best idea. Along with extending the template set by 24 hours, maybe just granting the student an additional test version would be good? Anyway, aside from introducing the constant for 24 hours in seconds, I did not change that one.

[Alex-Jordan]

I noticed I'd overlooked ReducedCred.pm. It's not in the default collection that gets used. I made similar updates to that one.

[somiaj]

Looking at the code I noticed a few things that I think could be cleaned up.

[drgrice1]

Looks okay to me.

[Alex-Jordan]

I fixed the conflicts and added to the descriptions.

[drgrice1]

I was testing using these achievement rewards with this pull request and got exceptions because the after method is not imported.

[Alex-Jordan]

Oh, I wonder if it was there before, but I resolved those qw conflicts without enough care.

[Alex-Jordan]

OK, after is imported in those three places now.

[drgrice1]

Yeah, I think it was. I thought this worked when I tested it before.

[drgrice1]

I noticed another issue when testing the ReducedCred reward (the Ring of Reduction). It is not due to this pull request, and doesn't need to be fixed here, but I am just noting it. I have reduced scoring enabled for the course, but I tested using it on a set that does not have reduced scoring enabled and received the message "This item won't work unless your instructor enables the reduced scoring feature. Let your instructor know that you received this message." It seems that the form should only present sets that have reduced scoring enabled.

Edit: I see now that the issue is that this tries to use the $pg{ansEvalDefaults}{reducedScoringPeriod} and I have that set to the default value of 0. So the issue is that the message that the achievement gives when this is 0 is not very useful for finding what is really going on.

[drgrice1]

Looks good now. Thanks for making those changes.