Fix rendering static images when checking answers in the PG problem editor. #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
render-problem-non-empty-filenames
branch
from
0294d84 to
b615eac
Compare
somiaj
approved these changes
Sep 19, 2024
drgrice1
force-pushed
the
render-problem-non-empty-filenames
branch
from
b615eac to
7af6b76
Compare
|
I haven't followed this issue, have not tried to understand the relevant code, and have not tested anything :) Just purely from looking at the code change from boolean testing And is it never the case that |
|
A filename of |
drgrice1
force-pushed
the
render-problem-non-empty-filenames
branch
from
7af6b76 to
7e01b0c
Compare
drgrice1
force-pushed
the
render-problem-non-empty-filenames
branch
from
7e01b0c to
87700bf
Compare
…ditor. This fixes issue openwebwork#2556 essentially as @somiaj suggests (although there is no need to first check that `$rh->{fileName}` is defined). The reason that `$rh->{fileName}` is defined is because the `default.html.ep` template always adds the `fileName` hidden field even when the `fileName` parameter is not defined in the original request. So if you click "Check Answers" it will be defined in `RenderProblem.pm` on that request.
drgrice1
force-pushed
the
render-problem-non-empty-filenames
branch
from
87700bf to
1f2fd3a
Compare
pstaabp
added a commit
that referenced
this pull request
Nov 12, 2024
…ames-hotfix Fix rendering static images when checking answers in the PG problem editor (hotfix of #2574)
pstaabp
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2556 essentially as @somiaj suggests (although there is no need to first check that
$rh->{fileName}is defined).The reason that
$rh->{fileName}is defined is because thedefault.html.eptemplate always adds thefileNamehidden field even when thefileNameparameter is not defined in the original request. So if you click "Check Answers" it will be defined inRenderProblem.pmon that request.