Fix the comment about the LTI 1.1 consumer key in the authen_LTI_1_1.conf.dist file. #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conf.dist file. The LMS course ID is not the issue. It is the LMS context id. That can be the same for two courses from different LMS's. So the `ConsumerKey` is used in that case to distinguish.
somiaj
approved these changes
Nov 13, 2024
|
I don't really see a reason to wait for a second approval, but @Alex-Jordan seems to be around, let's see if they can beat me to the merge again. |
Alex-Jordan
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LMS course ID is not the issue. It is the LMS context id. That can be the same for two courses from different LMS's. So the
ConsumerKeyis used in that case to distinguish. The course id could actually even be the same for two courses from the same LMS. However, that isn't used for this at all.