[chores] Formatted code, updated CI, update deps #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
update-ci
branch
5 times, most recently
from
9ef7d0c to
d39f889
Compare
Use PostgreSQL 15 for testing
auvipy
requested changes
Aug 13, 2024
pandafy
force-pushed
the
update-ci
branch
2 times, most recently
from
1ac2358 to
b1fe3de
Compare
Dropped support for Python 3.6 and 3.7 Dropped support for Django 2.2, 3.0, 3.1 and 4.0 Dropped support for djangorestframework < 3.12
Signed-off-by: Gagan Deep <pandafy.dev@gmail.com>
auvipy
previously approved these changes
Aug 14, 2024
nemesifier
reviewed
Aug 14, 2024
| django32: Django~=3.2.0 | ||
| django40: Django~=4.0.0 | ||
| djangorestframework310: djangorestframework~=3.10.0 | ||
| django42: Django~=4.2.0 |
There was a problem hiding this comment.
Can you please add the newer version of Django?
Signed-off-by: Gagan Deep <pandafy.dev@gmail.com>
nemesifier
reviewed
Aug 14, 2024
| django-filter>=2.0 | ||
| contexttimer | ||
| # QA checks | ||
| openwisp-utils[qa]~=1.0.5 | ||
| packaging~=20.4 | ||
| openwisp-utils[qa] @ https://github.com/openwisp/openwisp-utils/tarball/master |
There was a problem hiding this comment.
It would be better to publish openwisp-utils and use a stable version here.
nemesifier
requested changes
Aug 16, 2024
| django40: Django~=4.0.0 | ||
| djangorestframework310: djangorestframework~=3.10.0 | ||
| django42: Django~=4.2.0 | ||
| django50: Django~=5.0.0 |
There was a problem hiding this comment.
isn't django 5.1 missing here
| djangorestframework312: djangorestframework~=3.12.0 | ||
| djangorestframework313: djangorestframework~=3.13.0 | ||
| djangorestframework314: djangorestframework~=3.14.0 |
There was a problem hiding this comment.
isn't DRF 3.15.2 missing here?
nemesifier
changed the title
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use PostgreSQL 15 for testing