[BUG] MAC address set to uppercase when creating a registering a new #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…device openwisp#922 In device registration view, Made changes to the init object and included checked if attribute is mac_address then it should be changed to upper case Fixes openwisp#922 Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
nemesifier
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks @chahatsagarmain, but we need an automated test which replicates the bug (it must fail without the fix) to accept this patch.
|
@nemesifier where can i include the automated test ? can i add a method in |
Signed-off-by: chahatsagarmain <[email protected]>
nemesifier
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] MAC address set to uppercase when creating a registering a new
In device registration view, Made changes to the init object and included checked if attribute is mac_address then it should be changed to upper case
Fixes #922
Checklist