Skip to content

Commit

Permalink
[ci] Execute tests even if QA checks fail, build anyway
Browse files Browse the repository at this point in the history
  • Loading branch information
nemesifier committed Jul 4, 2024
1 parent 774c67d commit 9a2d810
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: OpenWRT OPENWISP MONITORING CI Build
---

name: OpenWRT OpenWISP Monitoring CI Build

on:
push:
Expand All @@ -22,11 +24,11 @@ jobs:
with:
python-version: "3.8"

- name: Install Python dependencies
run: pip install openwisp-utils[qa]

- name: Install Development dependencies
run: sudo ./install-dev.sh
- name: Install dependencies
id: deps
run: |
pip install openwisp-utils[qa]
sudo ./install-dev.sh
- name: QA-Checks
run: ./run-qa-checks
Expand All @@ -41,9 +43,11 @@ jobs:
sh_checker_comment: true

- name: Tests
if: ${{ !cancelled() && steps.deps.conclusion == 'success' }}
run: ./runtests

- name: Upload Coverage
if: ${{ success() }}
run: |
cd openwisp-monitoring/tests
luacov-coveralls -v
Expand All @@ -52,7 +56,6 @@ jobs:

build:
name: Build and upload package as artifacts
needs: tests
runs-on: ubuntu-20.04
env:
BUILD_DIR: '/home/runner/work/build'
Expand Down Expand Up @@ -87,6 +90,7 @@ jobs:
CI_CACHE: ${{ steps.cache.outputs.cache-hit }}

- name: Upload packages as artifacts
if: ${{ github.event_name=='push' }}
uses: actions/upload-artifact@v2
with:
name: Packages
Expand Down

0 comments on commit 9a2d810

Please sign in to comment.