[change] Random pause for every 10 successfull sent requests #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
requested changes
May 3, 2024
| @@ -195,6 +197,11 @@ send_data() { | |||
| done | |||
| # retry sending same data again in next cycle | |||
| [ "$failures" -eq "$MAX_RETRIES" ] && break | |||
| # pause for a while after every 10 successful request sent | |||
| if [ $((success_count % 10)) -eq 0 ]; then | |||
There was a problem hiding this comment.
Isn't 0 % 10 == 0 ? Why not just use [ $success_rate -ge 10 ] which is more readable?
There was a problem hiding this comment.
-ge makes it run whenever the success_rate is more than or equal to 10. But as per the issue, it was meant for every 10 requests. Was I right on this one?
There was a problem hiding this comment.
The requirement is to pause every 10 successful requests.
I don't see any success_rate variable in this diff, @pandafy where is success_rate coming from?
I only see success_count here.
nemesifier
reviewed
May 3, 2024
nemesifier
reviewed
May 3, 2024
nemesifier
reviewed
May 10, 2024
| @@ -118,6 +118,7 @@ handle_sigusr1() { | |||
| } | |||
|
|
|||
| send_data() { | |||
| success=1 | |||
There was a problem hiding this comment.
After having reviewed the code I think you were right in setting this to zero, my calculation was incorrect.
nemesifier
approved these changes
May 10, 2024
nemesifier
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128