config: clamp configurable values to within sensible ranges #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make 's' value a noop. Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
ra_lifetime no longer holds negative values, because we no longer do 'init' when we do calc_ra_lifetime, instead we do init at init time. Now ra_lifetime holds only >0 values. Signed-off-by: Paul Donald <[email protected]>
clamp values to RFC defined limits Signed-off-by: Paul Donald <[email protected]>
They never store negative values. Signed-off-by: Paul Donald <[email protected]>
This now prevents implicit 64 bit->32 bit truncation which may flag compiler errors later on down the road. All of the variables receiving from parse_leasetime() are uint32_t anyway, so max 136 years of valid lease time will have to suffice :) Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
(ipv6 packets can be up to 4GB in size...) The old logic had a logic error of || instead of && Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
|
ping @Ansuel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamp values read from config to RFC mandated sane values instead of just
complaining. Fixed also a bug in MTU handling.