-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wfb-ng: Add wfb-ng package #24974
wfb-ng: Add wfb-ng package #24974
Conversation
It seems |
I use direct git commit id as source so PKG_MIRROR_HASH is not needed |
@zpc0 I've fixed formal commit description, added Signed-by and PKG_MIRROR_HASH. Could you restart automatic workflow build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While looking at the readme in the repository, II see that there are only two supported WiFi chips and both requires external patched driver. I am not use, if this makes any sense for us since it requires so much work and it does not work out of the box unless you are using patched drivers.
net/wfb-ng/Makefile
Outdated
include $(TOPDIR)/rules.mk | ||
|
||
PKG_NAME:=wfb-ng | ||
PKG_VERSION:=24.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is not released nor tagged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/svpcom/wfb-ng/tree/wfb-ng-24.09-openwrt-preview
I've added tag for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a lot of requests from wfb-ng users that want to try wfb-ng on their wifi routers but for most of them compiling external packets is too hard that is why I've done this pull-request
net/wfb-ng/Makefile
Outdated
PKG_SOURCE_PROTO:=git | ||
PKG_SOURCE_URL:=https://github.com/svpcom/wfb-ng.git | ||
PKG_SOURCE_VERSION:=a41cd378e7e23dd094d6c50f26c4faa8e64e5954 | ||
PKG_MIRROR_HASH:=362b3d4262e78ae0885cc25cea34e553dc29e1941be47724ece796bd35220d88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to clone Git sources? We can use tarball. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO for review (or for compare changes between two different versions) direct link to git commit is more preferable than tarball
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing changes between two differents versions, thats why the tagged releases or tags are for. Still, I dont see reason, why BFU or the end user should care about your commit hashes, they want to have version and of course. Having double versioning in the Makefile, its odd even for developers. The version, which is not tagged, then it checkout sources and specific commit, no, no. Thats wrong.
Choose properly which one and I think you want to use tagged releases. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BKPepe Ok. I've replaced it with PKG_SOURCE_VERSION:=wfb-ng-24.09-openwrt-preview
now
@BKPepe In ath9k SoC (for example TP-Link CPE510) injection works out of box with standard driver. Also most of the cards supports monitoring mode and wfb-ng can work in RX-only mode with them
|
Hello, me and @zhouruixi (well mostly zhou) have verified several routers for wfb_ng and we are using it succesfully on them to operate drone video feeds. Like svpcom says, injection is only needed for bidirectional links, and for many drone operators(including me) unidirectional is enough. We already have 10 tested and verified working routers: https://github.com/OpenIPC/wfb-ng-openwrt/wiki/0.-Tested-devices It would be great for more routers to have injection, but for example having one cpe510 added to the mix is enough (i use two google wifi and one asus, soon one cpe510 to boost extra range). I have several kilometers range using this setup. Having wfb_ng easily available instead of building manually could revolutionize how OpenIPC can be used in the future, powered by OpenWRT+wfb_ng. Already runcam and EMAX is selling openipc hardware with users looking for a good transmission link layer setup. Zhou is spreading this also in his Chinese community and there will be many more users if we can simplify installation! |
It will be great if OpenWrt has the wfb-ng package. Almost all those IP Camera chips have old (~4.9) kernels and seems nobody gonna backport the new Wi-Fi drivers -- that's why only the RTL8812xU series adapters, with an out-of-kernel driver, were often heard in FPV scenarios. It will be easier for pilots to test monitor & packet injection on different adaptors supported by the mainline kernel if OpenWrt has the wfb-ng package. BTW, the ath9k injection works really well (on OpenWrt) :) |
6fc3e26
to
f815f92
Compare
681686b
to
235dde0
Compare
I hope this can move forward, I've been using wfb-ng (and it's predecessors) for some years and the prospect of using it on OpenWrt for a distributed receive network is really exciting. I've just purchased a couple of cpe510s as test nodes but am now learning how tricky it is to build compared to installing a package. Thank you to those working on this. |
How to fix error during CI build? Locally it builds without problems. |
Please squash your commits and rebase upon HEAD to see if CI builds. |
WFB-ng is long-range packet radio link based on raw WiFi radio. Adding it to openwrt base packages will help a lot of it users to use cheap wifi routers (supporting minitoring mode) instead of build custom hardware yourself. Signed-off-by: Vasily Evseenko <[email protected]>
@1715173329 done |
Merged, thank you! |
@1715173329 Thanks ! |
SNAPSHOT only currently. If you like I can pick this package to 24.10 branch so it will be available on OpenWrt 24.10+. |
@1715173329 Yes, please pick to 24.10 if possible |
done in 8999e9e. |
Thanks to @svpcom, good job! |
Maintainer: me
Compile tested: (MIPS 74Kc, TP-Link CPE510, openwrt-23.05)
Run tested: (MIPS 74Kc, TP-Link CPE510, tests done)
Description:
WFB-ng is long-range packet radio link based on raw WiFi radio.
Adding it to openwrt base packages will help a lot of it users to use cheap wifi routers (supporting minitoring mode) instead of build custom hardware yourself.