Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncthing: Update to 1.29.2 and Changed logfile path to /var/log/syncthing.log #25753

Closed
wants to merge 1 commit into from

Conversation

AutoCONFIG
Copy link

Maintainer: Paul Spooren [email protected], Van Waholtz [email protected]
Compile tested: x86-64(Ubuntu 24), master(24.10-rc3)
Run tested: x86-64, master(24.10-rc3), it's running normally.
Description:
The current version is two years old, and the default log path is under /etc/syncthing, which does not automatically clean up after restarting the machine or program, resulting in wasted storage space (especially for small embedded devices).

@efahl
Copy link
Contributor

efahl commented Jan 15, 2025

resulting in wasted storage space

Plus it wears out flash storage, so good move.

You need to reset PKG_RELEASE:=1 on a version bump.

Also, you should squash those two commits into one.

@AutoCONFIG
Copy link
Author

resulting in wasted storage space

Plus it wears out flash storage, so good move.

You need to reset PKG_RELEASE:=1 on a version bump.

Also, you should squash those two commits into one.

Thank you for the feedback! I've addressed the requested changes, including resetting PKG_RELEASE:=1 and squashing the commits into one. Please let me know if there's anything else that needs adjustment.

@efahl
Copy link
Contributor

efahl commented Jan 16, 2025

Looks good to me.

@1715173329
Copy link
Member

please:

  • sign DCO with your real name
  • shorten commit title (subject), like syncthing: Update to 1.29.2 and Change logfile path
  • wrap a new line for every 70 chars in your commit message

@AutoCONFIG
Copy link
Author

please:

* sign DCO with your real name

* shorten commit title (subject), like `syncthing: Update to 1.29.2 and Change logfile path`

* wrap a new line for every 70 chars in your commit message

Thank you for your feedback! I have processed the requested changes, please let me know if there are any corrections to be made!

@AutoCONFIG AutoCONFIG force-pushed the master branch 2 times, most recently from f34be2e to 4688bc3 Compare January 17, 2025 03:54
@1715173329
Copy link
Member

... I believe "AutoCONFIG" can't be a person's name.

Update to 1.29.2 and Change logfile path from /etc/syncthing/syncthing
log to /var/log/syncthing.log.
This utilizes tmpfs (memory-based storage) to prevent disk usage growth
caused by log file accumulation during extended operation.

Benefits:
- Avoids storage saturation from excessive log growth.
- Aligns with best practices for temporary log management.
- For systems using flash storage (e.g., SSDs or eMMC), storing logs in
  tmpfs avoids flash memory wear caused by frequent writes to
  /etc/syncthing.

Signed-off-by: Heng Wang <[email protected]>
@efahl
Copy link
Contributor

efahl commented Jan 17, 2025

@AutoCONFIG I'm curious why you closed this without merging? It looked like it was ready after that last change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants