FW-866. OpenRadio Implementation for OpenMote-B #516

minarady1 · 2020-08-06T20:23:34Z

No description provided.

…nrf52840, openmote, python, and silabs-ezr32wg

…y to uint8_t instead of uint16_t

minarady1 · 2020-08-07T11:17:21Z

To test this PR, just select each combination of timeslot template and radio setting in ieee154_init function.
This is an example of using the default setting:

    /* select the desired slot template to use, default is SLOT_20ms_24GHZ
       currently, the following slot template/radio setting combinations are supported:

        SLOT_20ms_24GHZ              , RADIOSETTING_24GHZ --> Default
        SLOT_40ms_24GHZ              , RADIOSETTING_24GHZ
        SLOT_40ms_FSK_SUBGHZ         , RADIOSETTING_FSK_OPTION1_FEC
        SLOT_40ms_OFDM1MCS0_3_SUBGHZ , RADIOSETTING_OFDM_OPTION_1_MCS0
        SLOT_40ms_OFDM1MCS0_3_SUBGHZ , RADIOSETTING_OFDM_OPTION_1_MCS1
        SLOT_40ms_OFDM1MCS0_3_SUBGHZ , RADIOSETTING_OFDM_OPTION_1_MCS2
        SLOT_40ms_OFDM1MCS0_3_SUBGHZ , RADIOSETTING_OFDM_OPTION_1_MCS3
    */
    ieee154e_select_slot_template (SLOT_20ms_24GHZ);
    ieee154e_vars.slotDuration      = slotTemplate.slotDuration;

    //set the radio setting to use, default is RADIOSETTING_24GHZ
    radio_setConfig (SLOT_20ms_24GHZ);

If you use the 40ms time slot template, make sure to have a frame size less than 50 (41 works) just to make sure that timeouts are still respected for upper layers.

changtengfei · 2020-08-07T14:10:05Z

bsp/boards/iot-lab_A8-M3/board.c

+
+//==== bootstrapping slot info lookup table
+void board_init_slot_vars(void){
+


Initialize the slot_board_vars variable here, i.e. using the memset(&slot_board_vars[0], 0, sizeof(slot_board_vars));

Need to check the value of sizeof(slot_board_vars).

changtengfei · 2020-08-07T14:22:53Z

bsp/boards/nrf52840/radio.c

@@ -193,6 +193,10 @@ void radio_reset(void) {
    radio_vars.state  = RADIOSTATE_STOPPED;


The same changes on board.c and board_info.h should apply on nRF52840 port.

changtengfei · 2020-08-07T14:25:07Z

bsp/boards/board.h

+
+// available slot templates
+typedef enum{
+    SLOT_10ms,


what's the modulation corresponding to SLOT_10ms

changtengfei · 2020-08-07T14:28:27Z

bsp/boards/openmote-b-24ghz/board.c

+//==== bootstrapping slot info lookup table
+void board_init_slot_vars(void){
+    //10ms slot
+    slot_board_vars [SLOT_10ms].slotDuration                         = 328 ;  // 10ms 


rename SLOT_10ms to SLOT_10ms_24GHZ and the following lines

changtengfei · 2020-08-07T14:31:16Z

bsp/boards/openmote-b/board.c

-   GPIOPinWrite(BSP_ANTENNA_BASE, BSP_ANTENNA_CC2538_24GHZ, BSP_ANTENNA_CC2538_24GHZ);
-   GPIOPinWrite(BSP_ANTENNA_BASE, BSP_ANTENNA_AT215_24GHZ, 0);
+void antenna_cc2538(void) {
+  GPIOPinWrite(BSP_ANTENNA_BASE, BSP_ANTENNA_CC2538_24GHZ, 0);


4 space for indentation everywhere

changtengfei · 2020-08-07T14:40:46Z

bsp/boards/openmote-b/leds.c

@@ -140,7 +140,7 @@ void leds_circular_shift(void) {
    // incrementally turn LED on
    for (i=0;i<10;i++) {
        bspLedSet(BSP_LED_1);
-        for (delay=0xffff;delay>0;delay--);
+        for (delay=0xffff;delay>0;delay--)


Please reverse this change.

changtengfei · 2020-08-07T14:43:47Z

bsp/boards/openmote-b/radio.c

+    dyn_funcs [RADIOSETTING_OFDM_OPTION_1_MCS2].radio_getReceivedFrame      =   radio_getReceivedFrame_at86rf215;
+    dyn_funcs [RADIOSETTING_OFDM_OPTION_1_MCS2].radio_isr                   =   radio_isr_at86rf215; 
+
+ //RADIOSETTING_OFDM_OPTION_1_MCS3


4 space indentation

changtengfei · 2020-08-07T14:44:02Z

bsp/boards/openmote-b/radio.c

+ //RADIOSETTING_OFDM_OPTION_1_MCS3
+    dyn_funcs [RADIOSETTING_OFDM_OPTION_1_MCS3].radio_reset                 =   radio_reset_at86rf215; 
+    dyn_funcs [RADIOSETTING_OFDM_OPTION_1_MCS3].radio_init                  =   radio_init_at86rf215; 
+    dyn_funcs [RADIOSETTING_OFDM_OPTION_1_MCS3].radio_setConfig     =   radio_setConfig_at86rf215; 


align the "equal"

changtengfei · 2020-08-07T14:44:53Z

bsp/boards/openmote-b/radio.c

 #include "board.h"
-#include "cc2538rf.h"
+
+#include "spi.h"


This header file is not required here

changtengfei · 2020-08-07T14:45:38Z

bsp/boards/openmote-b/spi.c

+
+#ifdef SPI_IN_INTERRUPT_MODE
+void spi_setCb(spi_cbt cb) {
+   spi_vars.spi_cb = cb;


indentation

changtengfei · 2020-08-07T14:46:13Z

bsp/boards/openmote-b/spi.c

+
+    // lower CS signal to have slave listening
+    if (spi_vars.isFirst==SPI_FIRST) {
+       GPIOPinWrite(SPI_GPIO_SSI_BASE, SPI_PIN_SSI_FSS, 0);


indentation here, please check the whole file.

changtengfei · 2020-08-07T14:49:43Z

bsp/boards/openmote-cc2538/cc2538sf53.lds

@@ -55,15 +55,6 @@ SECTIONS
        _ebss = .;
    } > SRAM

-    .heap (COPY):


Will those lines create issues? if not, please don't make changes

changtengfei · 2020-08-07T14:50:37Z

bsp/boards/samr21_xpro/board.c

@@ -149,7 +155,7 @@ void board_init(void)
 void rf_interface_init(void)
 {
 	pinmux_t pinmux;
-		/* Configure the RF233 SPI Interface */
+		//Configure the RF233 SPI Interface 


indentation

changtengfei · 2020-08-07T14:57:40Z

drivers/common/opentimers.c

@@ -8,6 +8,7 @@ at most MAX_NUM_TIMERS timers.
 */

 #include "opendefs.h"
+#include "board.h"   


this line is not required.

This reverts commit d0444e1.

…ers.c

…c2538 boards

…iot-lab_M3/board.c, silabs-ezr32wg/board.c, telosb/board.c, wsn430v13b/board.c, wsn430v14/board.c, and z1/board.c

changtengfei · 2020-08-13T11:13:52Z

bsp/boards/python/board_obj.c

-   }
-   Py_DECREF(result);
-
+    }


not aligned.

changtengfei · 2020-08-13T11:15:05Z

bsp/boards/python/board_obj.c

+
+// Setter/Getter function for slot_board_vars
+slot_board_vars_t board_selectSlotTemplate (slotType_t slot_type){
+  selected_slot_type = slot_type;


4 spaces for indentation

minarady1 added 23 commits August 6, 2020 14:44

fw-866 updates for openmoteb board

40d9668

fw-866 updates for iot-lab_A8-M3 board

7c1a372

fw-866 radio header update

a86fd1c

fw-866 open-tsch updates for iot-lab_M3 board

4ef68e8

fw-866 open-tsch updates for openmote-b-24ghz board

c639f94

fw-866 open-tsch updates for openmote-cc2538 board

d0444e1

fw-866 open-tsch updates for openmotestm board

a3edd27

fw-866 open-tsch updates for openmotestm board

33d6d1b

fw-866 open-tsch updates for python "board"

0bfed2c

fw-866 open-tsch updates for samr21_xpro board

81ade3f

fw-866 open-tsch updates for board.h

4147ab5

fw-866 OpenRadio driver update for at86rf215 chip

2a393fa

fw-866 OpenRadio driver update for at86rf231 chip

9606696

fw-866 OpenTSCH update for opentimers

301d6ee

fw-866 OpenRadio integration with IEEE802154E MAC

8f727a7

fw-866 added separate driver for the radio cc2538rf

ab27b2a

fw-866 updating openradio driver for at86rf215

1942d1e

fw-866 updating slot timing reference in the stack

744e556

fw-866 added radio_setConfig definition to radio.c drivers of boards …

785a2e1

…nrf52840, openmote, python, and silabs-ezr32wg

fw-866 restoring the data type for the frequency in radio_setFrequenc…

5ef02df

…y to uint8_t instead of uint16_t

fw-866 fixed typos in radio drivers

662c56e

fw-866 fixing resetStats identifier in pyhton SConscript.env

e4cacd4

fw-866 adding SConscript to cc2538rf chip folder

163a70c

changtengfei changed the title ~~develop_FW-866_PR2~~ FW-866. OpenRadio Implementation for OpenMote-B Aug 7, 2020

fw-866 restoring the default setting for the radio

ed65d22

minarady1 requested review from changtengfei, twatteyne and TimothyClaeys August 7, 2020 11:51

changtengfei reviewed Aug 7, 2020

View reviewed changes

bsp/boards/openmote-b/spi.c

#ifdef SPI_IN_INTERRUPT_MODE

void spi_setCb(spi_cbt cb) {

spi_vars.spi_cb = cb;

Copy link

Member

changtengfei Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

changtengfei reviewed Aug 7, 2020

View reviewed changes

minarady1 added 14 commits August 7, 2020 21:57

fw-866 updating SLOT_10ms slot name to SLOT_10ms_24GHZ

97259dd

Revert "fw-866 open-tsch updates for openmote-cc2538 board"

a0b074d

This reverts commit d0444e1.

fw-866 typos fix and .gitignore update

8e6b14d

fw-866 fixing indentation and styling

d9006f5

fw-866 styling + removing unnecessary header from radio.c and opentim…

eeaceb1

…ers.c

fw-866 updating board drivers for nrf52840 board

a023655

fw-866 styling fixes

a71ee8e

fw-866 renaming SLOT_10ms to SLOT_10ms_24GHZ in python and openmote-c…

1b3882c

…c2538 boards

fw-866 renaming SLOT_10ms to SLOT_10ms_24GHZ in openmote-b-24ghz/board.c

38170c3

fw-866 styling

4ff6ca7

fw-866 changing L2_SECURITY_ACTIVE to OPENWSN_IEEE802154E_SECURITY_C

af5bcfe

fw-866 updating board drivers with OpenTSCH support in gina/board.c, …

457dd04

…iot-lab_M3/board.c, silabs-ezr32wg/board.c, telosb/board.c, wsn430v13b/board.c, wsn430v14/board.c, and z1/board.c

fw-866 styling+comments

84f6375

fw-866 iot-lab_M3/board.c initializing slots

783d3fe

changtengfei reviewed Aug 13, 2020

View reviewed changes

bsp/boards/python/board_obj.c

}

Py_DECREF(result);

}

Copy link

Member

changtengfei Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not aligned.

changtengfei reviewed Aug 13, 2020

View reviewed changes

fw-866 styling in python board

e1e4ccd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FW-866. OpenRadio Implementation for OpenMote-B #516

FW-866. OpenRadio Implementation for OpenMote-B #516

minarady1 commented Aug 6, 2020

minarady1 commented Aug 7, 2020 •

edited

Loading

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020 •

edited

Loading

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020

changtengfei Aug 7, 2020 •

edited

Loading

changtengfei Aug 13, 2020

changtengfei Aug 13, 2020


		//==== bootstrapping slot info lookup table
		void board_init_slot_vars(void){

		@@ -193,6 +193,10 @@ void radio_reset(void) {
		radio_vars.state = RADIOSTATE_STOPPED;

FW-866. OpenRadio Implementation for OpenMote-B #516

Are you sure you want to change the base?

FW-866. OpenRadio Implementation for OpenMote-B #516

Conversation

minarady1 commented Aug 6, 2020

minarady1 commented Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changtengfei Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changtengfei Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minarady1 commented Aug 7, 2020 •

edited

Loading

changtengfei Aug 7, 2020 •

edited

Loading

changtengfei Aug 7, 2020 •

edited

Loading