-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXCH-10878 Native support for OpenX bidder #10
base: master
Are you sure you want to change the base?
Conversation
places we can think about additional tests:
|
src/test/resources/org/prebid/server/it/openrtb2/openx/test-native-response.json
Outdated
Show resolved
Hide resolved
@@ -29,4 +29,19 @@ public void openrtb2AuctionShouldRespondWithBidsFromOpenx() throws IOException, | |||
// then | |||
assertJsonEquals("openrtb2/openx/test-auction-openx-response.json", response, singletonList("openx")); | |||
} | |||
|
|||
@Test | |||
public void openrtb2AuctionWithNativeShouldRespondWithBidsFromOpenx() throws IOException, JSONException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: we are considering removing this test case since it seems to be duplicated with the unit tests and it looks like this test level is not dedicated to test the features, but integration only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to our recent conversation, maybe it would be worth to add a test case verifying what will be returned from makeHttpRequest
when there is multi-ad-placement imp in bid request?
having the PR here to have the checks running