Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yurtadm join: support deploying local mode yurthub in systemd #2190

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huangchenzhao
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature
/kind question

What this PR does / why we need it:

#2124

In local mode, yurtadm join should support deploying yurthub in systemd, and join the local node to K8s cluster in user's IDC

@huangchenzhao huangchenzhao marked this pull request as draft November 18, 2024 02:33
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 9.24370% with 108 lines in your changes missing coverage. Please review.

Project coverage is 45.02%. Comparing base (7763e7c) to head (37eaf3c).
Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
pkg/yurtadm/util/localnode/localnode.go 0.00% 53 Missing ⚠️
pkg/yurtadm/cmd/join/phases/prepare.go 0.00% 20 Missing ⚠️
pkg/yurtadm/cmd/join/join.go 40.74% 14 Missing and 2 partials ⚠️
pkg/yurtadm/cmd/join/phases/postcheck.go 0.00% 11 Missing ⚠️
pkg/yurtadm/util/initsystem/initsystem_unix.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2190       +/-   ##
===========================================
- Coverage   58.93%   45.02%   -13.91%     
===========================================
  Files         210      403      +193     
  Lines       18968    27828     +8860     
===========================================
+ Hits        11179    12530     +1351     
- Misses       6707    14070     +7363     
- Partials     1082     1228      +146     
Flag Coverage Δ
unittests 45.02% <9.24%> (-13.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant