feat: support forward requests to leader hub for sharing pool scope metadata in nodepool #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambohe-ch
force-pushed
the
support-pool-scope-metadata-in-pool
branch
2 times, most recently
from
8f25132 to
2e41ba9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2325 +/- ##
==========================================
+ Coverage 45.70% 45.97% +0.26%
==========================================
Files 394 394
Lines 25953 26103 +150
==========================================
+ Hits 11861 12000 +139
- Misses 12946 12952 +6
- Partials 1146 1151 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
force-pushed
the
support-pool-scope-metadata-in-pool
branch
3 times, most recently
from
4514d42 to
cbef4f1
Compare
tnsimon
reviewed
Feb 17, 2025
cmd/yurthub/app/options/options.go
Outdated
| @@ -167,6 +171,19 @@ func (options *YurtHubOptions) Validate() error { | |||
| if len(options.CACertHashes) == 0 && !options.UnsafeSkipCAVerification { | |||
| return fmt.Errorf("set --discovery-token-unsafe-skip-ca-verification flag as true or pass CACertHashes to continue") | |||
| } | |||
|
|
|||
| if len(options.NodePoolName) == 0 { | |||
| return fmt.Errorf("node-pool-name is empty") | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("node-pool-name is empty") | |
| return errors.New("node-pool-name is empty") |
tnsimon
reviewed
Feb 17, 2025
| if !ok { | ||
| return | ||
| } | ||
| oldCfg, _ := oldObj.(*corev1.ConfigMap) |
There was a problem hiding this comment.
Should we not check the "ok" value still?
There was a problem hiding this comment.
because FilterFunc in configmap informer as following can ensure only configmap object is transferred to event handlers.
configmapInformer.AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: func(obj interface{}) bool {
cfg, ok := obj.(*corev1.ConfigMap)
if ok && cfg.Name == util.YurthubConfigMapName {
return true
}
return false
},
Handler: cache.ResourceEventHandlerFuncs{
AddFunc: m.addConfigmap,
UpdateFunc: m.updateConfigmap,
DeleteFunc: m.deleteConfigmap,
},
})
tnsimon
reviewed
Feb 17, 2025
| oldCM, _ := oldObj.(*corev1.ConfigMap) | ||
| newCM, _ := newObj.(*corev1.ConfigMap) | ||
|
|
||
| if reflect.DeepEqual(oldCM.Data, newCM.Data) { |
There was a problem hiding this comment.
maps.Equal(...) is a new std lib for comparing maps.
rambohe-ch
force-pushed
the
support-pool-scope-metadata-in-pool
branch
3 times, most recently
from
f2e80fc to
c86a55a
Compare
…etadata in nodepool. Signed-off-by: rambohe-ch <[email protected]>
rambohe-ch
force-pushed
the
support-pool-scope-metadata-in-pool
branch
from
c86a55a to
be43355
Compare
|
|
/LGTM |
zyjhtangtang
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
openyurt.io/configmap-name: {configmap-name}is added to these two configmaps.make local-up-openyurtas following:openyurt-e2e-test-control-planenode intoyurt-pool1openyurt-e2e-test-workerandopenyurt-e2e-test-worker2nodes intoyurt-pool2openyurt-e2e-test-worker3andopenyurt-e2e-test-worker4nodes intoyurt-pool3Which issue(s) this PR fixes:
Fixes #2261
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note