feat: add printer columns for leaders #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2333 +/- ##
=======================================
Coverage 45.96% 45.97%
=======================================
Files 394 394
Lines 26103 26107 +4
=======================================
+ Hits 11998 12002 +4
Misses 12953 12953
Partials 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
reviewed
Feb 19, 2025
tnsimon
force-pushed
the
enhance-nodepools-statusfields
branch
from
2f9c3b3 to
253a821
Compare
rambohe-ch
reviewed
Feb 19, 2025
tnsimon
force-pushed
the
enhance-nodepools-statusfields
branch
from
dde2f0f to
15caeda
Compare
|
rambohe-ch
approved these changes
Feb 19, 2025
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds status information to the nodepool when using
k get nodepoolsWhich issue(s) this PR fixes:
Fixes #2331
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note