Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always resize too big images #109

Merged
merged 3 commits into from
Dec 6, 2024

Pass only width to resize image and keep aspect ratio

cf87e36
Select commit
Loading
Failed to load commit list.
Merged

Always resize too big images #109

Pass only width to resize image and keep aspect ratio
cf87e36
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 6, 2024 in 1s

49.27% (+0.04%) compared to 31b0fcb

View this Pull Request on Codecov

49.27% (+0.04%) compared to 31b0fcb

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.27%. Comparing base (31b0fcb) to head (cf87e36).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/asset.py 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   49.23%   49.27%   +0.04%     
==========================================
  Files          20       20              
  Lines        1170     1175       +5     
  Branches      164      165       +1     
==========================================
+ Hits          576      579       +3     
- Misses        583      585       +2     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov