Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve and rewrite Detailed licensing pages content #98

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

benoit74
Copy link
Contributor

Fix #54

@benoit74 benoit74 self-assigned this Nov 26, 2024
@benoit74 benoit74 marked this pull request as ready for review November 26, 2024 16:23
@benoit74 benoit74 requested a review from rgaudin November 26, 2024 16:23
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 49.68%. Comparing base (7a97c59) to head (e793254).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...src/mindtouch2zim/libretexts/detailed_licensing.py 68.42% 12 Missing ⚠️
scraper/src/mindtouch2zim/processor.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   49.10%   49.68%   +0.57%     
==========================================
  Files          17       18       +1     
  Lines        1065     1107      +42     
  Branches      149      151       +2     
==========================================
+ Hits          523      550      +27     
- Misses        531      546      +15     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@benoit74 benoit74 force-pushed the detect_special_pages branch from a86df2c to 2fe399a Compare December 6, 2024 12:31
Base automatically changed from detect_special_pages to main December 6, 2024 12:36
@benoit74 benoit74 merged commit b3c8911 into main Dec 6, 2024
10 checks passed
@benoit74 benoit74 deleted the detailed_licensing branch December 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly render Detailed Licensing pages of libretexts.org
2 participants