Return to forward slash mandatory before paths to support root wikis #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
api_path_slashes
branch
2 times, most recently
from
3b785ac to
9f21430
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
==========================================
- Coverage 75.88% 75.84% -0.04%
==========================================
Files 41 41
Lines 3222 3225 +3
Branches 706 706
==========================================
+ Hits 2445 2446 +1
- Misses 660 662 +2
Partials 117 117 ☔ View full report in Codecov by Sentry. |
kelson42
force-pushed
the
api_path_slashes
branch
from
9f21430 to
abe3fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2163
Mostly everything is explained in the issue, basically we want to support
--mwWikiPath /since it is a common scenario, and the simplest way to support this is to consider that all path have a forward slash at the beginning, and that the base URLs don't.