Meson using libmagic pkgconfig #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgautierfr I guess we use an old version of libmagic (at least in our CI container) because it works fine on my Ubuntu 22.04? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 27.43% 27.55% +0.11%
==========================================
Files 26 26
Lines 2544 2519 -25
Branches 1389 1344 -45
==========================================
- Hits 698 694 -4
- Misses 1333 1354 +21
+ Partials 513 471 -42 ☔ View full report in Codecov by Sentry. |
|
Depends on kiwix/kiwix-build#617 |
kelson42
force-pushed
the
use-libmagic-pkgconfig
branch
from
c4292b1
to
328e2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #344
Unfortunately we can not fix it for the moment because Focal uses an old version (5.38) of libmagic and pkgconfig support has been added in 5.39.
But for all other system we use now the standard procedure and hopefuly we can remove the old custom code soon when Focal will move forward.