Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail with 500 error when unknown HTTP verb is sent #1001

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

benoit74
Copy link
Collaborator

Rationale

Fix #838

Changes

  • simply handle the fact that HTTP verb might be unknown in BaseRoute class

@benoit74 benoit74 self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (9ad012b) to head (2448e28).
Report is 4 commits behind head on main.

Files Patch % Lines
dispatcher/backend/src/routes/base.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
+ Coverage   88.14%   88.21%   +0.07%     
==========================================
  Files          94       95       +1     
  Lines        5312     5331      +19     
==========================================
+ Hits         4682     4703      +21     
+ Misses        630      628       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review July 23, 2024 12:52
@benoit74 benoit74 merged commit ebe4912 into main Jul 23, 2024
5 checks passed
@benoit74 benoit74 deleted the unknown_http_method branch July 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP HEAD verb is raising 500 errors
1 participant