Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that ZIM title must not be longer than 30 chars on our ZIMs #1024

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 8, 2024

Rationale

Fix #777

Changes

  • add new validation method for ZIM titles (no longer than 30 chars)
  • setup this validation method on title metadata on all offliners

Nota : some scraper might not yet properly check for the 30 chars limit, but this is not a valid reason to not block at Zimfarm level to avoid using more than 30 characters.

@benoit74 benoit74 self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (2657147) to head (fe905c2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          97       97           
  Lines        5414     5415    +1     
=======================================
+ Hits         4783     4784    +1     
  Misses        631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 requested a review from rgaudin October 8, 2024 14:04
@benoit74 benoit74 marked this pull request as ready for review October 8, 2024 14:13
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 8f81caf into main Oct 10, 2024
7 checks passed
@benoit74 benoit74 deleted the zim_title branch October 10, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that Title should be max 30 characters long
2 participants