Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exception when recording IP changes fails #1050

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Log exception when recording IP changes fails #1050

merged 1 commit into from
Nov 18, 2024

Conversation

benoit74
Copy link
Collaborator

Rationale

  • When recording the IP change fails, we have no clue in the logs about what happened
  • I also changed slightly the message so that it is clearer that the problem is not in our DB (which has been updated) but in pushing the changes to Wasabi

@benoit74 benoit74 self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (040a78d) to head (6ec8b8a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          98       98           
  Lines        5448     5449    +1     
=======================================
+ Hits         4817     4818    +1     
  Misses        631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74
Copy link
Collaborator Author

@rgaudin I did not asked for formal review and merged right away because it is minor and I needed the code in production, but feedbacks are welcomed

@benoit74 benoit74 marked this pull request as ready for review November 18, 2024 08:13
@benoit74 benoit74 merged commit 3194ca6 into main Nov 18, 2024
7 checks passed
@benoit74 benoit74 deleted the record_ip_msg branch November 18, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant