Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
All
requests
operations should have a timeout otherwise the code is waiting indefinitely for an HTTP response.Notifications (at the end of a task) must have such a timeout.
Default timeout is small (5 secs) to avoid issues if not set (no reason to wait for a process which is "fire-and-forget" by design).
An HTTP timeout during a notification is catched and logged as an error but will not stop further notification to proceed and will not stop the changes to be commited to the DB.
This is a tentative to enhance situation on #817.
Changes