Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts for GHCR + CMS requests #820

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add timeouts for GHCR + CMS requests #820

merged 1 commit into from
Sep 19, 2023

Conversation

benoit74
Copy link
Collaborator

Rationale

See #817 for details

Changes

  • add timeout to requests to GHCR + CMS
  • timeout values have a default of 10 secs, which can be override by an environment variable
  • more homogeneity in environment variables / constants naming across all requests timeouts

rgaudin
rgaudin approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ; can you please update zimfarm config on k8s to specify all those (to make tweaking config easier) and also (in that config) specify a 60s timeout for cms to balance it's current perf issue

@benoit74 benoit74 merged commit d41e428 into main Sep 19, 2023
@benoit74 benoit74 deleted the add_all_timeout branch September 19, 2023 08:42
@benoit74 benoit74 mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit74 @rgaudin