Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing schedule name #830

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Fix missing schedule name #830

merged 6 commits into from
Sep 27, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 26, 2023 •
edited
Loading

Rationale

Changes

  • a new log line is writen when a CMS error occurs, so that we can search for it in Grafana ("CMS errors" indicator is now broken since we do not have the exception anymore since dispatcher/backend: Remove zmq broadcaster + enhance CMS error handling #827
  • fix a test issues where tests where not re-entrant
  • add a frontend-dev-ui development container with hot reload of development changes, very useful for UI development
  • store in DB original_schedule_name in requested_tasks and tasks
  • expose the original_schedule_name to the API along the schedule_name which will remain empty in youzimit
  • adapt UI to a missing schedule_name and use the original one.
  • add a Jupyter notebook to test code e.g. SQLAlchemy query + move existing one in dev folder which is more appropriate

@benoit74 benoit74 force-pushed the missing_schedule_name branch from 85dee79 to 93725dc Compare September 26, 2023 13:28
@benoit74 benoit74 requested a review from rgaudin September 26, 2023 13:36
@benoit74 benoit74 self-assigned this Sep 26, 2023
@benoit74 benoit74 force-pushed the missing_schedule_name branch from 37f228e to 84f4a04 Compare September 26, 2023 13:37
rgaudin
rgaudin approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ; I think we can skip the condition in entrypoint.

dispatcher/frontend-ui/entrypoint.sh Outdated
@@ -1,11 +1,14 @@
#!/bin/sh

JS_PATH=/usr/share/nginx/html/environ.json
echo "dump ZIMFARM_* environ variables to $JS_PATH"
if [ -z "${ENVIRON_PATH}" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better set it in both Dockerfile and minimize this

@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 27, 2023 •
edited
Loading

Thank you, I've fixed and resolved obvious conversations.
I let you check the change regarding ENVIRON_PATH and merge once ok.

@benoit74 benoit74 requested a review from rgaudin September 27, 2023 06:29
rgaudin
rgaudin approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rgaudin rgaudin merged commit 74341bc into main Sep 27, 2023
@rgaudin rgaudin deleted the missing_schedule_name branch September 27, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zimfarm at youzim.it doesn't show schedule names
2 participants
@benoit74 @rgaudin