Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_requested property to schedule endpoints #840

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

benoit74
Copy link
Collaborator

Rationale

Fix #720

Changes

  • new is_requested property on GET /schedules/ and GET /schedules/{schedule_name} endpoints
  • for GET /schedules/, property is computed based on an addition to the complex SQL Query retrieving schedules and their properties
  • for GET /schedules/{schedule_name}, property is computed based on an additional SQL Query (transparent) to retrieve requested_tasks of current schedule (not an issue since we have only one schedule and rarely a requested_task)
  • UI does not use the GET /requested_tasks endpoint anymore, column is sourced directly from is_requested property

@benoit74 benoit74 marked this pull request as ready for review September 29, 2023 13:42
@benoit74 benoit74 requested a review from rgaudin September 29, 2023 13:43
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; thanks 👍

@rgaudin rgaudin merged commit 7474c66 into main Sep 29, 2023
5 checks passed
@rgaudin rgaudin deleted the add_is_requested branch September 29, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule column always empty under certain conditions
2 participants