Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance youtube flags and enhance StringEnum UI handling #843

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Enhance youtube flags and enhance StringEnum UI handling #843

merged 3 commits into from
Oct 6, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 6, 2023 •
edited
Loading

Changes

  • In the schedule config UI, when the flag type is "StringEnum", the "Not set" option is not shown in the combobox when the flag is required
  • Youtube flags are re-order so that:
    • important parameter are displayed first in the list
    • flags which are specific to one mode (normal or playlists) are grouped together
    • expert flags are grouped at the end of the list
  • Youtube flags descriptions are enhanced:
    • flags specific to one mode (normal or playlists) are clearly indicated
    • no technical flag identifier is used in descritpion, only flag display names are used
    • subtle wording changes, more precisions, ...
  • API key is set a secret

@benoit74 benoit74 self-assigned this Oct 6, 2023
@benoit74 benoit74 changed the title Fix youtube flags and enhance StringEnum UI handling Enhance youtube flags and enhance StringEnum UI handling Oct 6, 2023
@benoit74 benoit74 requested a review from rgaudin October 6, 2023 10:04
@benoit74 benoit74 marked this pull request as ready for review October 6, 2023 10:04
rgaudin
rgaudin requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ; it looks good but there's a few questions

dispatcher/backend/src/common/schemas/offliners/youtube.py Show resolved Hide resolved
dispatcher/backend/src/common/schemas/offliners/youtube.py Outdated Show resolved Hide resolved
dispatcher/backend/src/common/schemas/offliners/youtube.py Outdated Show resolved Hide resolved
dispatcher/backend/src/common/schemas/offliners/youtube.py Outdated Show resolved Hide resolved
dispatcher/frontend-ui/src/components/ScheduleEditor.vue Show resolved Hide resolved
@benoit74 benoit74 requested a review from rgaudin October 6, 2023 11:57
rgaudin
rgaudin approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rgaudin rgaudin merged commit 05fcfdd into main Oct 6, 2023
5 checks passed
@rgaudin rgaudin deleted the fix_youtube_flags branch October 6, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit74 @rgaudin