Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lang flag to kolibri and publisher flag to gutenberg #903

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add lang flag to kolibri and publisher flag to gutenberg #903

merged 3 commits into from
Jan 17, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jan 17, 2024 •
edited
Loading

Rationale

Fix #899
Fix #902

Changes

  • to simplify the codebase, it is now a requirement that all scrapers integrated into the Zimfarm has a publisher flag to customize the ZIM publisher

@benoit74 benoit74 self-assigned this Jan 17, 2024
@benoit74 benoit74 changed the title Add lang flag to kolibri offliner Add lang flag to kolibri and publisher flag to gutenberg Jan 17, 2024
@benoit74 benoit74 marked this pull request as ready for review January 17, 2024 14:59
@benoit74 benoit74 requested a review from rgaudin January 17, 2024 14:59
rgaudin
rgaudin approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rgaudin rgaudin merged commit 8efa9b3 into main Jan 17, 2024
5 checks passed
@rgaudin rgaudin deleted the update_offliners branch January 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gutenberg scraper now supports the publisher flag Add --lang flag to kolibri offliner definition
2 participants
@benoit74 @rgaudin