Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP rdr2geo + geo2rdr unit tests #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LiangJYu
Copy link
Contributor

@LiangJYu LiangJYu commented May 11, 2022

This PR is based the rdr2geo and geo2rdr unit tests @hfattahi created for the now deprecated Cython ISCE3. All test inputs are generated by the test. The objective for the this PR is have the 4 following tests:

  1. rdr2geo with satellite orbit over equator and zero DEM with zero DEM
  2. rdr2geo with satellite orbit over constant 45° lat with zero DEM
  3. rdr2geo with satellite orbit over equator and zero DEM with zero DEM
  4. rdr2geo with satellite orbit over constant 45° lat with zero DEM

TBD:

  • Decide whether to use existing SimpleNamespace to mimic RunConfig shortcut or introduce test yamls and SAFE zip for comprehensiveness. Using SimpleNamespace.

To do:

  • debug so rdr2geo test passes
  • implement both equator and 45° lat geo2rdr tests
  • more documentation and comments

LiangJYu added 5 commits May 10, 2022 17:03
differentiate start times
removed double arccos
fixed raster band index
omega 0.1 -> 0.001
save expected height in cfg
add more comments
@LiangJYu
Copy link
Contributor Author

LiangJYu commented Jul 8, 2022

The rdr2geo test is currently failing because the DEM interpolator is returning the wrong height. The indices computed by DEM interpolator do not fall within the synthetic DEM so the default value (DEM average) is returned for all points in the radar grid. I think a couple things need addressing:

  • a DEM that fits the radar grid. I'm not sure how to do this.
  • ability to change DEM interp method to nearest neighbor so the DEM can remain small. This I can fix.

Since the Cython rdr2geo test tests point by point, it avoids this problem by changing the DEM interpolator default value to expected height per point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant