orbit type when orbit_file_path is a list
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshiroma
reviewed
Sep 5, 2023
There was a problem hiding this comment.
LGTM, @seongsujeong . Thank you for the update. I just have one minor comment below.
Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
gshiroma
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to take care of the case when a list of orbit file was provided in RTC-S1's runconfig when populating the orbit information into
/metadata/orbit/orbitTypein metadata.In case of using restituted orbit (RESORB) file, there is a rare chance that a single RESORB file does not cover sentinel-1 frame's sensing start/stop with ~100 minutes of margin at the sensing start. The margin is necessary to ensure at least one ascending node crossing event before sensing start, so that ascending node crossing time (ANX time) can be corrected properly.
In case when the list of orbit file was provided, it extracts the types of each individual orbit file, concatenate them with a separator
;, and put the string into/metadata/orbit/orbitType.