More changes for the RTC-S1 SAS Release 5 (R5) #73
Conversation
|
Retest this, please |
|
Sorry, @seongsujeong , I have a few more updates. Would you mind taking a look at this PR again when you have a chance? Thanks |
…tute underbars with dashes in product type
…n as an attribute of boundingBox
…n as an attribute of boundingBox (2)
| @@ -466,12 +490,24 @@ def get_metadata_dict(product_id: str, | |||
|
|
|||
| if not estimated_geometric_accuracy_bias_y: | |||
| estimated_geometric_accuracy_bias_y = '(UNSPECIFIED)' | |||
| else: | |||
| estimated_geometric_accuracy_bias_y = float( | |||
There was a problem hiding this comment.
This variable is from cfg_in.groups.processing.geocoding.estimated_geometric_accuracy_bias_y, and according to schema, it can be either None or a number. Any reason that you are casting it to float?
There was a problem hiding this comment.
Yes, if the user provides the value estimated_geometric_accuracy_bias_y = 1, the data type of the output will be integer rather than float.
| # ['is_urgent_observation', False, | ||
| # 'List of booleans indicating if datatakes | ||
| # are nominal or urgent'], | ||
| 'identification/diagnosticModeFlag': |
There was a problem hiding this comment.
Please make sure that the removal of this field is in sync with the spec.
There was a problem hiding this comment.
Yes, I updated it accordingly. Thanks, @seongsujeong
This PR updates:
"1.0.0-beta"or1.0.0).diagnosticModeFlagfrom the HDF5 metadata.productSpecificationVersionis nowstringandburstGeogridSnapX,burstGeogridSnapY,rangeBandwidth, andmaxNoiseEquivalentSigmaZeroare nowfloat.