Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for v1.0.2 #82

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Changes for v1.0.2 #82

merged 10 commits into from
Mar 11, 2024

Conversation

gshiroma
Copy link
Collaborator

@gshiroma gshiroma commented Mar 6, 2024 •
edited
Loading

This PR updates the RTC SAS for v1.0.2. Changes:

  • Reorder call to GDAL band WriteArray() to fix issues with GDAL >= 3.8.
  • Update setting of the static-layers data access with substrings "{burst_id}" and "{end_date}".

@gshiroma gshiroma changed the title Changes for v1.0.2 (WIP) Changes for v1.0.2 Mar 6, 2024
seongsujeong
seongsujeong reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I have some minor suggestion as below.

src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
@gshiroma
use format() rather than replace() to populate the static-layer data …
0d9c58a 
…access; extend functionality to source data access and product data access
seongsujeong
seongsujeong approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@gshiroma gshiroma merged commit ebb175f into opera-adt:main Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seongsujeong seongsujeong seongsujeong approved these changes

@hfattahi hfattahi Awaiting requested review from hfattahi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gshiroma @seongsujeong