Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all RTC-S1 products if at least one child process fails #85

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

gshiroma
Copy link
Collaborator

This PR updates the software to address a critical issue where RTC-S1 products were not being removed from the output directory if a child process failed. Previously, when a child process failed, the corresponding product was not deleted as expected. While the ideal solution would be to selectively remove only the products associated with failed processes, achieving this would require additional changes to the code, extensive retesting, and verification of a large number of products produced by the OPERA Science Data System, which is not feasible at this time.

Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in this PR looks straightforward about what it wants to do. Below are my few suggestions.

src/rtc/rtc_s1.py Show resolved Hide resolved
src/rtc/rtc_s1.py Show resolved Hide resolved
src/rtc/rtc_s1.py Show resolved Hide resolved
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gshiroma
Copy link
Collaborator Author

Thank @seongsujeong !

@gshiroma gshiroma merged commit f92a38b into opera-adt:main Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants