-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frame definition #8
Conversation
- The version was manually written in setup.py and didnt match version.py - The setup.py script had a few errors, and didnt install correctly
This reverts commit 444a948.
…tructue/instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My additional comments are as below. I have not reviewed frames.py
yet. Please let me know if the code is ready. - Seongsu
Co-authored-by: Seongsu Jeong <[email protected]>
Co-authored-by: Seongsu Jeong <[email protected]>
Co-authored-by: Seongsu Jeong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottstanie Thanks for taking care of my comments. Here are some minor comments. Most of them are for aesthetics, except for the variable name zip
. - Seongsu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR and taking care of my comments @scottstanie
Script for making a DB with a
frames
table, along with a join table to select all bursts for a frame.relative_orbit_number
s.opera-create-db
, which will download all the necessary files and create the 2 dbs (one full one, one burst with just 5 columns that's only 22 MB zipped up)You can grab all the bursts for a frame combination using using the query