🌱 [Monorepo] Fix make verify-crd-compatibility for catalogd #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camilamacedo86
force-pushed
the
fix-crd-diff-catalogd
branch
3 times, most recently
from
e19760f to
4d17ca8
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
- Coverage 67.42% 67.35% -0.07%
==========================================
Files 55 55
Lines 4632 4644 +12
==========================================
+ Hits 3123 3128 +5
- Misses 1284 1291 +7
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
force-pushed
the
fix-crd-diff-catalogd
branch
3 times, most recently
from
c134fc1 to
575a701
Compare
The `verify-crd-compatibility` check needs to be executed from the root directory; otherwise, it fails to correctly resolve commit SHAs for comparison. To address this, we have combined the checks for both CRDs into a single verification step, ensuring correctness while eliminating duplicate file references.
camilamacedo86
force-pushed
the
fix-crd-diff-catalogd
branch
from
575a701 to
7a51015
Compare
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Merged
via the queue into
operator-framework:main
with commit Jan 30, 2025
c5e9a17
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To proceed, we needed to skip the check when the previous commit is not found. However, this results in the
verify-crd-compatibilitycheck always being skipped for catalogd. Example: https://github.com/operator-framework/operator-controller/actions/runs/13016547026/job/36307072381?pr=1653#step:4:68Simply reverting the
verify-crd-compatibilitytarget and fixing the path to include catalogd will not work because the check must be executed from the root directory; otherwise, it fails to correctly resolve to commit SHAs for comparison.To address this, we have combined the checks for both CRDs into a single verification step, ensuring correctness while eliminating duplicate file references.