✨ Separate CA configuration for pulls vs catalogd services #1673
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 67.42% 67.43%
=======================================
Files 55 57 +2
Lines 4632 4621 -11
=======================================
- Hits 3123 3116 -7
+ Misses 1284 1278 -6
- Partials 225 227 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
grokspawn
reviewed
Jan 30, 2025
tmshort
force-pushed
the
pull-cert-dir
branch
from
2db703d to
5e67403
Compare
tmshort
force-pushed
the
pull-cert-dir
branch
from
5e67403 to
19f3513
Compare
|
@camilamacedo86 I just updated this PR (as you were reviewing it) to keep the old flag, but mark it as deprecated, and to only use it only when the new flags aren't used. Log messages will indicate use of the deprecated flag. |
tmshort
force-pushed
the
pull-cert-dir
branch
from
19f3513 to
ced1054
Compare
joelanford
reviewed
Jan 30, 2025
joelanford
reviewed
Jan 30, 2025
tmshort
force-pushed
the
pull-cert-dir
branch
from
ced1054 to
ab90d41
Compare
tmshort
force-pushed
the
pull-cert-dir
branch
from
ab90d41 to
f4d9445
Compare
|
New changes are detected. LGTM label has been removed. |
tmshort
force-pushed
the
pull-cert-dir
branch
from
f4d9445 to
66b078e
Compare
Rename the flags that provide CAs to image pulling to indicate the use. Keep the old flag around (for backward compatibility), but prefer the new flag(s). Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
pull-cert-dir
branch
from
66b078e to
eabd8d2
Compare
joelanford
approved these changes
Jan 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:main
with commit Jan 30, 2025
c3a4406
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the options that provide CAs to image pulling to indicate the use.