-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Rename util packages and add missing unit tests #1677
🌱 Rename util packages and add missing unit tests #1677
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7548295
to
bd1ef6c
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
bd1ef6c
to
0d4d124
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
+ Coverage 67.50% 67.72% +0.21%
==========================================
Files 57 57
Lines 4632 4620 -12
==========================================
+ Hits 3127 3129 +2
+ Misses 1278 1266 -12
+ Partials 227 225 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
0d4d124
to
fdf0c32
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
fdf0c32
to
3e69d9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
d065a49
Description
Follow up to #1669
SetReadOnlyRecusive
andSetWritableRecursive
for simplicityReviewer Checklist