Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Rename util packages and add missing unit tests #1677

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

perdasilva
Copy link
Contributor

Description

Follow up to #1669

  • Renames utils package to fsutil (in line with bundleutil and httputil packages)
  • Adds unit test coverage to the public functions that were introduced
  • Refactors SetReadOnlyRecusive and SetWritableRecursive for simplicity

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 3e69d9a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/679cd0785e8e25000820fbb2
😎 Deploy Preview https://deploy-preview-1677--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva perdasilva force-pushed the address-fix-comments branch 5 times, most recently from 7548295 to bd1ef6c Compare January 31, 2025 11:31
@perdasilva perdasilva changed the title 🌱 Rename util package and add unit tests 🌱 Rename util packages and add missing unit tests Jan 31, 2025
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the address-fix-comments branch from bd1ef6c to 0d4d124 Compare January 31, 2025 11:43
@perdasilva perdasilva marked this pull request as ready for review January 31, 2025 11:54
@perdasilva perdasilva requested a review from a team as a code owner January 31, 2025 11:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 63.26531% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (c3a4406) to head (3e69d9a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/rukpak/source/helpers.go 68.88% 10 Missing and 4 partials ⚠️
catalogd/cmd/catalogd/main.go 0.00% 1 Missing ⚠️
catalogd/internal/source/containers_image.go 0.00% 0 Missing and 1 partial ⚠️
cmd/operator-controller/main.go 0.00% 0 Missing and 1 partial ⚠️
internal/rukpak/source/containers_image.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   67.50%   67.72%   +0.21%     
==========================================
  Files          57       57              
  Lines        4632     4620      -12     
==========================================
+ Hits         3127     3129       +2     
+ Misses       1278     1266      -12     
+ Partials      227      225       -2     
Flag Coverage Δ
e2e 53.35% <42.55%> (-0.05%) ⬇️
unit 54.48% <63.26%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azych azych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@perdasilva perdasilva enabled auto-merge January 31, 2025 12:33
@perdasilva perdasilva force-pushed the address-fix-comments branch from 0d4d124 to fdf0c32 Compare January 31, 2025 13:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the address-fix-comments branch from fdf0c32 to 3e69d9a Compare January 31, 2025 13:30
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@perdasilva perdasilva enabled auto-merge January 31, 2025 14:04
@perdasilva perdasilva added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 31, 2025
Merged via the queue into operator-framework:main with commit d065a49 Jan 31, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants