-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (cleanup): remove duplication of version implementation #1728
🌱 (cleanup): remove duplication of version implementation #1728
Conversation
Before catalogd and operator-controller requires have a code implementation to set the Version. However, now both projects are the same and have the same version. Therefore, has no longer reason to keep both
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WDYT? Can we move forward with this one already? An alternative solution would be to create a sub-directory like shared, as @azych suggested, and place the version there. However, IMHO, all libraries might be used for both. The only component-specific part is the controllers. In fact, the feature gates could be shared as well. Given that, I’d argue for centralizing everything rather than introducing a more complex structure. That said, I’ll defer to you since you might have a different long-term vision. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
+ Coverage 67.99% 68.24% +0.24%
==========================================
Files 59 58 -1
Lines 4993 4988 -5
==========================================
+ Hits 3395 3404 +9
+ Misses 1358 1342 -16
- Partials 240 242 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d72e551
Follow up of: #1728
Before catalogd, the operator-controller requires a code implementation to set the Version. However, now both projects are the same and have the same version. Therefore, there is no longer a reason to keep both.
Motivated by: #1707