🌱 updated macos-specific brew installs to include coreutils for mktemp package #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…package Signed-off-by: Jordan Keister <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 58 58
Lines 4988 4988
=======================================
Hits 3404 3404
Misses 1342 1342
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -145,7 +145,7 @@ Some additional setup is necessary on Macintosh computers to install and configu | |||
| Follow the instructions to [install Homebrew](https://docs.brew.sh/Installation), and then execute the following command to install the required tools: | |||
| ```sh | |||
| brew install bash gnu-tar gsed | |||
| brew install bash gnu-tar gsed coreutils | |||
There was a problem hiding this comment.
I think that could sort out my scenario as well 👍
There was a problem hiding this comment.
Yes, I think so, and I was trying to make use of your "fresh eyes" here to spot where we could fix any gaps (#1733 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist