-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [Monorepo]: Move the hack demo scripts to the root #1739
🌱 [Monorepo]: Move the hack demo scripts to the root #1739
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
06e8ccb
to
1fbf046
Compare
1fbf046
to
495dda4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 58 58
Lines 4988 4988
=======================================
Hits 3404 3404
Misses 1342 1342
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -118,9 +118,3 @@ build-container: build-linux ## Build docker image for catalogd. | |||
kind-load: $(KIND) ## Load the built images onto the local cluster | |||
$(CONTAINER_RUNTIME) save $(IMAGE) | $(KIND) load image-archive /dev/stdin --name $(KIND_CLUSTER_NAME) | |||
|
|||
##@ Deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's apparently no Deploy section in the op-con Makefile help. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the demo should be under the doc section as it is right?
Should we create a Deploy section
Does it make sense we add it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the demo-update now
$ make
bash clean-venv fix-lint kind-cluster release test-ext-dev-e2e
bingo-upgrade crd-ref-docs fmt kind-deploy run test-unit
build debug-venv generate kind-load run-latest-release test-upgrade-e2e
build-deps demo-update go-build-linux lint serve-docs tidy
build-docs deploy-docs go-build-local manifests shell venv
build-linux docker-build help operator-controller show-venv verify
catalogd-e2e e2e help-extended post-upgrade-checks test verify-crd-compatibility
catalogd-image-registry e2e-coverage image-registry pre-upgrade-setup test-catalogd-e2e wait
catalogd-post-upgrade-checks envtest-k8s-bins ipython python test-catalogd-upgrade-e2e zsh
catalogd-pre-upgrade-setup extension-developer-e2e kind-clean
b110f2b
to
7389dd4
Compare
@tmshort rebased :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
Closes: #1704
We are moving the demo scripts to the root
In the future, we might want to update the demo to be of the whole project instead only catalogd.
Local Test
Reviewer Checklist